[UR][L0][L0v2] Refactor reference counting in UR L0 and L0v2 #19057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
refCountRefactorL0
branch
from
8e897f6 to
d5ce48c
Compare
RossBrunton
reviewed
Jun 23, 2025
RossBrunton
reviewed
Jun 23, 2025
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
refCountRefactorL0
branch
2 times, most recently
from
08d30d0 to
080a36d
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
refCountRefactorL0
branch
from
080a36d to
331bfb1
Compare
martygrant
requested a deployment
to
WindowsCILock
GitHub Actions
In progress
martygrant
force-pushed
the
refCountRefactorL0
branch
from
331bfb1 to
658e368
Compare
martygrant
force-pushed
the
refCountRefactorL0
branch
from
658e368 to
6b2c4bb
Compare
martygrant
added a commit
to martygrant/llvm
that referenced
this pull request
Jun 27, 2025
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
refCountRefactorL0
branch
from
44b4c09 to
17bb480
Compare
martygrant
force-pushed
the
refCountRefactorL0
branch
from
17bb480 to
ebcbfa0
Compare
martygrant
added a commit
to martygrant/llvm
that referenced
this pull request
Jul 2, 2025
…to inherit common reference counting functionality. Update L0 and L0V2 to use this.
…r can start ref count from 0
…to any relevant handles that need ref counting.
…espace. Add a constructor for the class with a default value and remove use of reset() inside the Adapter constructor, using the RefCount constructor to set default value instead.
…nd decrementAndTest -> release, and remove decrement as it doesn't get used.
martygrant
force-pushed
the
refCountRefactorL0
branch
from
ebcbfa0 to
1c400e4
Compare
|
Failing |
RossBrunton
approved these changes
Jul 2, 2025
kbenzie
approved these changes
Jul 2, 2025
pbalcer
approved these changes
Jul 2, 2025
martygrant
added a commit
to martygrant/llvm
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #18644
Most UR adapters had their own reference counting of some sort. This adds a new
RefCountclass and refactors adapter code so all adapters can share the same code for reference counting. This PR handles L0/L0V2 and I will open more PRs for each adapter in turn.